Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playground: set grafana topology in pd #1142

Merged
merged 3 commits into from
Feb 22, 2021
Merged

playground: set grafana topology in pd #1142

merged 3 commits into from
Feb 22, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Feb 20, 2021

What problem does this PR solve?

fix #1007

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2021
@codecov-io
Copy link

codecov-io commented Feb 20, 2021 •
edited
Loading

Codecov Report

Merging #1142 (1aaf2c3) into master (ffed4ff) will decrease coverage by 19.68%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1142       +/-   ##
===========================================
- Coverage   53.61%   33.93%   -19.69%     
===========================================
  Files         285      242       -43     
  Lines       20319    17708     -2611     
===========================================
- Hits        10895     6010     -4885     
- Misses       7756    10698     +2942     
+ Partials     1668     1000      -668
Flag Coverage Δ
cluster 36.34% <ø> (-8.69%) ⬇️
dm ?
integrate 33.93% <0.00%> (-14.05%) ⬇️
playground 2.93% <0.00%> (-0.01%) ⬇️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/instance.go 0.00% <0.00%> (ø)
components/playground/instance/pd.go 0.00% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/playground/instance/tidb.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash.go 0.00% <0.00%> (ø)
components/playground/instance/tikv.go 0.00% <0.00%> (ø)
components/playground/playground.go 0.00% <0.00%> (ø)
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffed4ff...1aaf2c3. Read the comment docs.

@9547 9547 changed the title Fix/playground update grafana playground: set grafana topology in pd Feb 20, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: efd133f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-chi-bot
Copy link
Member

@9547: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 405b908 into pingcap:master Feb 22, 2021
lucklove pushed a commit to lucklove/tiup that referenced this pull request Mar 4, 2021
@jsvisa @ti-chi-bot @lucklove
playground: set grafana topology in pd (pingcap#1142)
4ecc95a 
* refact(playground): expose func advertiseHost

* feat(playground): set grafana topo into pd

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
@9547 9547 deleted the fix/playground-update-grafana branch April 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstroProfundis AstroProfundis AstroProfundis approved these changes

@lonng lonng Awaiting requested review from lonng

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tiup playground is not reporting the Grafana address
5 participants
@9547 @codecov-io @ti-chi-bot @AstroProfundis @jsvisa